-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ModelServingST test #114
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
jiridanek
force-pushed
the
jd_multimodelserving
branch
2 times, most recently
from
March 17, 2024 21:06
26b69bb
to
026efaa
Compare
kornys
requested changes
Mar 18, 2024
jstourac
reviewed
Mar 18, 2024
jstourac
reviewed
Mar 18, 2024
jstourac
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did a quick review, two minor comments. Othewise LGTM with my very limited knowledge about the background of this!
jiridanek
force-pushed
the
jd_multimodelserving
branch
from
March 18, 2024 11:26
026efaa
to
95b2b85
Compare
jiridanek
force-pushed
the
jd_multimodelserving
branch
from
March 18, 2024 11:29
95b2b85
to
ef29770
Compare
jstourac
approved these changes
Mar 18, 2024
kornys
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.